1. randomLevel() returns an int in the interval [1.. MAX_LEVEL], but the comment says “[0 - MAX_LEVEL}” (note the curly bracket too)

2. Since skip-lists are essentially sorted sets you should probably implement SortedSet.

3. I believe (but didn’t check) most JRE collections have custom implementations when something can be done faster. For example addAl(Collection) is (randomized) O(n lg n) the way you do it, but it can be done in O(n) if the collection is actually a sorted set (which you can test).

4. Even if the interface has contains(Object) it’s probably nicer if you overload with contains(E), so that clients who say “SkipList s=…; s.contains(e);” don’t go thru the cast check.

5. DISTRIUBUTION and MAX_LEVEL could be set by the user.

6. Does the generic toArray work (without warnings)? I thought the only way to do it is to use the magic java.lang.reflect.Array.newInstance (directly or indirectly).

7. You might want to look at the implementation in the last section here: http://infoarena.ro/skiplists

8. It would be nice to give some numbers on how it compares to TreeSet time/space-wise.

9. Since you spent time to write it nicely, it would be nice if people would use it. You should consider sending it as a patch to a library like Apache Commons Collections (http://commons.apache.org/collections/). (I use google collections but they don’t say how to send patches, at least i didn’t find how.)

Blog trends Started by Chris: 0
Blog trends Started by Eugene: 1